Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factorio-demo: init at 0.14.23 #25265

Merged
merged 2 commits into from Apr 30, 2017
Merged

factorio-demo: init at 0.14.23 #25265

merged 2 commits into from Apr 30, 2017

Conversation

layus
Copy link
Member

@layus layus commented Apr 27, 2017

No description provided.

@mention-bot
Copy link

@layus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @elitak, @Baughn and @mpscholten to be potential reviewers.

@elitak
Copy link
Contributor

elitak commented Apr 28, 2017

For me, the demo tarball downloaded is gzip compressed, so renaming it to .xz causes the unpack phase to fail. You'll need to provide a modified name attr to the fetch instead of inheriting the common one.

Also maybe fix the inconsistent spacing around the fetchurl/authenticatedFetch/abort (right-justify the verbs) and maybe rename versions to releases.

@layus
Copy link
Member Author

layus commented Apr 28, 2017

@elitak How can it fail for you and not for me ? This is scarier than the issue itself.

@elitak
Copy link
Contributor

elitak commented Apr 28, 2017

@layus Run file /nix/store/*factorio-demo*tar.[gx]z and see if the contents match the extensions. I can't really offer an explanation for this behavior on the master branch unless you rebased from an older one, since I think the tar xaf behavior in stdenv changed to xz -d | tar x at some point in recent history. Regardless, the extensions should match the contents of any files written to the store, especially when used as src attributes.

@layus
Copy link
Member Author

layus commented Apr 28, 2017

@elitak It wan indeed the rebase. Factorio uses xz for 0.15.x apparently, and the demo is still stuck at 0.14.x. Also fixed the other nitpicks.

@joachifm joachifm merged commit 92f53af into NixOS:master Apr 30, 2017
joachifm pushed a commit that referenced this pull request Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants