pythonXXPackages.httpserver: init at 1.1.0 #25256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@P-E-Meunier, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer. |
FRidh
requested changes
Apr 30, 2017
pkgs/top-level/python-packages.nix
Outdated
| @@ -2964,6 +2964,33 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| httpserver = buildPythonPackage rec { | |||
There was a problem hiding this comment.
please move expression to pkgs/development/python-modules/httpserver/default.nix
pkgs/top-level/python-packages.nix
Outdated
| pname = "httpserver"; | ||
| version = "1.1.0"; | ||
| buildInputs = with self; [ docopt ]; | ||
| doCheck = false; |
There was a problem hiding this comment.
why do you disable the tests? If you disable the tests, always include a comment.
pkgs/top-level/python-packages.nix
Outdated
| version = "1.1.0"; | ||
| buildInputs = with self; [ docopt ]; | ||
| doCheck = false; | ||
| src = pkgs.fetchurl { |
pkgs/top-level/python-packages.nix
Outdated
| @@ -22154,6 +22181,7 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
|
|
|||
|
Don't merge, rebase instead. If you need help with it or like me to do it let me know. |
|
Please go ahead! If this PR requires me to start fiddling with git, I'm willing to abandon this it. |
|
there it is 5db271c |
|
Awesome! Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
SimpleHTTPServer is a python package that starts an HTTP server serving files in the local directory.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)