virtualisation-xen: Fix xendomains startup #25257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently, the
xendomains
service fails to start the xen VMs, failing with the error:The reason for this is that the
xendomains
script expects to be run usingbash
, but the build script rewrites its shebang line to point atsh
:Additionally, the script would fail because of trying to run
/bin/ls
.This pull request fixes both problems.
Please note that
/bin/ls
was already being substituted byls
before commit 9e6ae2f was applied. That commit removed a number of other substitutions, which might need to be revisited.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)