Skip to content

Commit

Permalink
qsyncthingtray: allow building with qt 5.8
Browse files Browse the repository at this point in the history
  • Loading branch information
peterhoeg committed Apr 27, 2017
1 parent d3bf2af commit e89343d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
8 changes: 7 additions & 1 deletion pkgs/applications/misc/qsyncthingtray/default.nix
Expand Up @@ -36,9 +36,14 @@ stdenv.mkDerivation rec {
'';

installPhase = let qst = "qsyncthingtray"; in ''
runHook preInstall
mkdir -p $out/bin
install -m755 QSyncthingTray $out/bin/${qst}
ln -s $out/bin/${qst} $out/bin/QSyncthingTray
wrapQtProgram $out/bin/qsyncthingtray
runHook postInstall
'';

meta = with stdenv.lib; {
Expand All @@ -52,6 +57,7 @@ stdenv.mkDerivation rec {
license = licenses.lgpl3;
maintainers = with maintainers; [ zraexy peterhoeg ];
platforms = platforms.all;
broken = builtins.compareVersions qtbase.version "5.7.0" >= 0;
# 0.5.7 segfaults when opening the main panel with qt 5.7 but qt 5.8 is OK
broken = builtins.compareVersions qtbase.version "5.7.0" == 0;
};
}
4 changes: 2 additions & 2 deletions pkgs/top-level/all-packages.nix
Expand Up @@ -15251,8 +15251,8 @@ with pkgs;
qt = qt4;
};

# 0.5.7 segfaults when opening the main panel with qt 5.7
qsyncthingtray = libsForQt56.callPackage ../applications/misc/qsyncthingtray { };
# 0.5.7 segfaults when opening the main panel with qt 5.7 but qt 5.8 is OK
qsyncthingtray = libsForQt5.callPackage ../applications/misc/qsyncthingtray { };

qsynth = callPackage ../applications/audio/qsynth { };

Expand Down

2 comments on commit e89343d

@zraexy
Copy link
Member

@zraexy zraexy commented on e89343d May 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to have broken the build but I'm not entirely sure why. When building with Qt 5.8 it can't find WebEngineWidgets which should still be part of qtwebengine. This occurs both on my system and on Hydra.

@peterhoeg
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very strange. I had it working on 5.8 but now it's indeed broken. Just pushed a fix to force it back to 5.6.

Please sign in to comment.