Make --arg work for undeclared arguments #1363
Conversation
This commit makes the `--arg` and `--argstr` cli options work even if
the evaluated function doesn't explicitly declare this argument.
For example `nix-instantiate --eval -E "{...}@Args: args.foo" --arg foo
1` now apply the function with the argument `{ foo = 1 }` (thus returns
`1`) instead of quietly ignoring the `arg foo 1` option (and returning
`<LAMBDA>`)
Note that `nix-instantiate --eval -E "args: args.foo" --arg foo 1` now
also returns `1`.
Fixes NixOS#1360
|
Cool! I haven't been able to test it yet but that looks like it will fix the issue I was having. One thing to be careful of is that this is changing behavior for all |
|
I quickly grepped the nix repo, and it looks like Other than that, I've ran a couple of |
|
I marked this as stale due to inactivity. → More info |
Make the
--argand--argstrcli options work even ifthe evaluated function doesn't explicitly declare this argument.
For example
nix-instantiate --eval -E "{...}@args: args.foo" --arg foo 1now apply the function with the argument{ foo = 1 }(thus returns1) instead of quietly ignoring thearg foo 1option (and returning<LAMBDA>):nix-instantiate --eval -E "args: args.foo" --arg foo 1now also returns1.I assumed that the actual behavior (
--argargument dropped when thecorresponding argument isn't explicitly declared) isn't intended and is a bug,
let me know if it isn't.
This should fix #1360