pyproj: enable tests, use bundled proj by default #25870
Merged
+17
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, I was using |
|
Hmmm for 1.9.5.1 the only log info is
So I think it's best summed up as "unspecified version". (this is why I advocate using git submodules when it's absolutely positively necessary to bundle/fork a dependency) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Funny story, I'd actually totally independently packaged pyproj myself at around the same time, but wasn't able to submit it due to an internet outage. Anyway...
I managed to get the tests working for this, but to get them to pass I had to switch to using the bundled version of
proj, though still allowing the possibility for a systemprojto be used if desired.Again, if you like I'll add myself as maintainer of this.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)