Emoji shortcode #2748
Merged
Emoji shortcode #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
reviewed
May 8, 2017
| @@ -0,0 +1,46 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # This file is public domain according to its author, Brian Hsu | |||
Kwpolska
reviewed
May 8, 2017
|
|
||
|
|
||
| class Plugin(ShortcodePlugin): | ||
| """Plugin for gist directive.""" |
|
Looks good, but perhaps we could merge all those JSON files into a more compact, manageable format of |
added 2 commits
May 8, 2017 12:55
|
@Kwpolska yeah, I could merge them but then I would need to do it again if I ever refresh that data. |
|
@ralsina I didn’t expect you to do it by hand. |
|
Also, there are two turkey emojis! (bird and country, I guess) |
Kwpolska
reviewed
May 9, 2017
| @@ -0,0 +1,21 @@ | |||
| The MIT License (MIT) | |||
|
|
|||
| Copyright (c) 2016 -2017 Shayan Rais | |||
There was a problem hiding this comment.
Add a link to the repo somewhere.
|
Done. Also added docs.
…On Tue, May 9, 2017 at 10:33 AM Chris Warrick ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In nikola/plugins/shortcode/emoji/data/LICENSE
<#2748 (comment)>:
> @@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2016 -2017 Shayan Rais
Add a link to the repo <https://github.com/shanraisshan/EmojiCodeSheet>
somewhere.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2748 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAGK71ChbHD3kxXKCBqfggeSpW0rSKgks5r4GsjgaJpZM4NUGe4>
.
|
Kwpolska
approved these changes
May 9, 2017
| output = '''<span class="emoji">{}</span>'''.format(TABLE[name]) | ||
| except KeyError: | ||
| LOGGER.warning('Unknown emoji {}'.format(name)) | ||
| output = '''<span class="emoji, error">{}</span>'''.format(name) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
A simple shortcode for emoji support: {{% emoji cry_face %}}