Compiler: fixed is_a? transform may cause an exception #4390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed crystal-lang#4364 `(Something.some_method).is_a?(Const)` will transform to `Const === Something.some_method` It should clone the `node.const` and `node.obj` to do this work.
|
What? |
|
Just close and re-open the PR. It'll automatically restart the build. |
|
@kirbyfan64 Thanks! |
|
Thanks! Looks good to me, I'm just running a couple of quick benchmarks and unless I find something odd there I'll merge it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #4364
This code may trigger an exception about enclosing call.
This will be transformed to below:
The compiler checks enclosing call of
Something.some_methodtwice, and causes an exception.So, cloning the
ASTNodecould solve this bug.