hpx: restrict architecture to x86_64 #25614
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobakker
changed the title
|
If anyone wants to see the logs, here they are. |
Mic92
reviewed
May 9, 2017
| @@ -20,7 +20,7 @@ stdenv.mkDerivation rec { | |||
| description = "C++ standard library for concurrency and parallelism"; | |||
| homepage = "https://github.com/STEllAR-GROUP/hpx"; | |||
| license = stdenv.lib.licenses.boost; | |||
| platforms = stdenv.lib.platforms.linux; | |||
| platforms = [ "x86_64-linux" ]; # stdenv.lib.platforms.linux; | |||
There was a problem hiding this comment.
would ["i686-linux" "x86_64-linux"] also work?
|
@Mic92 i686 doesn't build on hydra either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Hydra spits out some build errors on aarch64, so I've set the architecture to x86_64 for now.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)