activator: remove package from package-set #25616
Conversation
|
@Ma27, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edwtjo, @cko and @NeQuissimus to be potential reviewers. |
|
btw it seems as the XCode build fails because of a failed download, but that should be unrelated to my change, shouldn't it? |
| @@ -6320,8 +6320,6 @@ with pkgs; | |||
|
|
|||
| ### DEVELOPMENT / TOOLS | |||
|
|
|||
| activator = callPackage ../development/tools/activator { }; | |||
There was a problem hiding this comment.
I'm not sure if we have a general policy on this, but I generally appreciate it when instead of removing derivation attributes, we replace them with something like throw "Typesafe Activator was removed in X for reason Y. See https://github.com/NixOS/nixpkgs/pull/25616 for more information", and then eventually we delete the attribute. This gives people a way to figure out what went wrong (although nix-env will just break silently, but fixing that is more work) even if they can't get the package.
I think there are probably better ways to do this in a more systematic way, but until we've agreed on those, I'd prefer a throw
There was a problem hiding this comment.
done. It gives me now the following output when trying to build:
→ nix-build -A activator
error: Typesafe Activator was removed in 2017-05-08 as the actual package reaches end of life.
See https://github.com/NixOS/nixpkgs/pull/25616
and http://www.lightbend.com/community/core-tools/activator-and-sbt
for more information.
I've squashed it into the previous commit as it directly belongs to this change.
the typesafe activator is about to reach end of life at the end of this month (2017-05) and the servers will be decommissioned at the ond of 2017. See http://www.lightbend.com/community/core-tools/activator-and-sbt for and the project's readme (https://github.com/typesafehub/activator/blob/master/README.md) for further reference.
|
well...why does travis try to build the openjdk? This will take years... |
|
@copumpkin anything else tbd? |
|
👍 |
Motivation for this change
the typesafe activator is about to reach end of life at the end of this
month and the servers will be decommissioned at the end of 2017.
See http://www.lightbend.com/community/core-tools/activator-and-sbt for
and the project's readme
(https://github.com/typesafehub/activator/blob/master/README.md) for further reference.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)