Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csdp: fix darwin build #25217

Merged
merged 2 commits into from Apr 30, 2017
Merged

csdp: fix darwin build #25217

merged 2 commits into from Apr 30, 2017

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Apr 25, 2017 •
edited

Motivation for this change

Fixes build failure introduced by #24152

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Apr 25, 2017
@mention-bot
Copy link

@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @oconnorr, @vbgl and @dezgeg to be potential reviewers.

@vbgl
Copy link
Contributor

vbgl commented Apr 26, 2017

csdp builds but does not seem to run:

$ ./result/bin/csdp
dyld: Library not loaded: libblas.so.3.5.0
  Referenced from: $PWD/./result/bin/csdp
  Reason: image not found
[1]    99129 trace trap  ./result/bin/csdp

@LnL7
csdp: fix darwin build
2bd39ab 
the build sets CC=clang causing it to essentially ignore the cc wrapper
@LnL7
blas: fix darwin library id
f240276
@LnL7
Copy link
Member Author

LnL7 commented Apr 27, 2017

@vbgl Good catch, I tested coq so I just assumed it worked.

@LnL7 LnL7 merged commit 5e3de39 into NixOS:master Apr 30, 2017
@LnL7 LnL7 deleted the darwin-csdp branch April 30, 2017 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @mention-bot @vbgl