Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mono: 4.6.0 -> 4.6.2 #25221

Merged
merged 1 commit into from Apr 30, 2017
Merged

mono: 4.6.0 -> 4.6.2 #25221

merged 1 commit into from Apr 30, 2017

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Apr 25, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@kuznero
Copy link
Member Author

kuznero commented Apr 26, 2017

Building for Xcode fails with timeout error it seems. Please help how to proceed with that.

@kuznero kuznero mentioned this pull request Apr 26, 2017
Closed
7 tasks
@copumpkin
Copy link
Member

What do you mean building for Xcode? Darwin? We don't really use Xcode anywhere in Nix today, and if something depends on it, we try to prevent that.

@kuznero
Copy link
Member Author

kuznero commented Apr 27, 2017 •
edited

@copumpkin Sorry for confusion. What I meant is the last third step in TravisCI build system. It is called Xcode. A bit misleading perhaps. But currently the build is green.

@bachp
Copy link
Member

bachp commented Apr 29, 2017

Is it really necessary to have 4.6.2 in addition to 4.6.0.182? Can't you just upgrade the 4.6 package?

@kuznero
Copy link
Member Author

kuznero commented Apr 30, 2017

@bachp I think having 4.6.2 is more important than having 4.6. I agree that upgrading 4.6 to 4.6.2 is better approach. I will upgrade 4.6 and ping when it is done (as part of this same PR). Thanks for input!

@kuznero kuznero changed the title mono: init at 4.6.2 mono: 4.6.0 -> 4.6.2 Apr 30, 2017
@FRidh
Copy link
Member

FRidh commented Apr 30, 2017

@kuznero can you rename your commit to mono: 4.6.0 -> 4.6.2

@kuznero
Copy link
Member Author

kuznero commented Apr 30, 2017

@FRidh done

@FRidh
Copy link
Member

FRidh commented Apr 30, 2017

cc maintainers @obadz @vrthra @thoughtpolice

@obadz obadz merged commit 86fe3e9 into NixOS:master Apr 30, 2017
@kuznero kuznero deleted the mono462 branch April 30, 2017 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kuznero @copumpkin @bachp @FRidh @obadz