Reject functions with required keyword-only arguments #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sophist-UK
reviewed
May 1, 2017
test/test_script.py
Outdated
| register_script_function(func) | ||
|
|
||
| def test_optional_kwonly_parameters(self): | ||
| def func(a, *, required_kwarg=1): |
There was a problem hiding this comment.
s/required_kwarg/optional_kwarg/
zas
approved these changes
May 1, 2017
Python 3 / PEP3102 introduced keyword-only arguments, like in
def foo(a, *, b):
pass
where `b` can't be set as a positional argument. This can't be expressed in
tagger script, so reject calls to register such functions.
This also gets rid of a DeprecationWarning for inspect.getargspec.
Signed-off-by: Wieland Hoffmann <themineo@gmail.com>
mineo
added a commit
that referenced
this pull request
May 1, 2017
Reject functions with required keyword-only arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 / PEP3102 introduced keyword-only arguments, like in
where
bcan't be set as a positional argument. This can't be expressed intagger script, so reject calls to register such functions.
This also gets rid of a DeprecationWarning for inspect.getargspec.