srcml: init -> 0.9.5 #25395
srcml: init -> 0.9.5 #25395
Conversation
|
|
||
| patchPhase = '' | ||
| patchShebangs . | ||
| substituteInPlace CMake/install.cmake --replace /usr/local $out |
There was a problem hiding this comment.
prePatch is preferred to not break the usage of patches = [].
| ''; | ||
|
|
||
| nativeBuildInputs = [ ]; | ||
| buildInputs = [ libxml2 libxslt boost cmake libarchive python antlr ]; |
There was a problem hiding this comment.
cmake and antlr belongs to nativeBuildInputs
| buildInputs = [ libxml2 libxslt boost cmake libarchive python antlr ]; | ||
|
|
||
| configurePhase = '' | ||
| cmake -DCMAKE_INSTALL_PREFIX=$out . |
There was a problem hiding this comment.
this should be default, did you try dropping this phase?
There was a problem hiding this comment.
Indeed, it works without.
| with stdenv.lib; | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "srcml"; |
There was a problem hiding this comment.
pname does not serve a purpose here.
There was a problem hiding this comment.
I use this pattern everywhere, and hope that there will semantic version names soon - at which point it will. Is it okay to leave as is?
There was a problem hiding this comment.
Can you explain what benefit this layer of indirection provides. I do not see, where pname is used.
| name = "${pname}-${version}"; | ||
|
|
||
| src = fetchurl { | ||
| url = "http://www.sdml.cs.kent.edu/lmcrs/srcML-src.tar.gz"; |
There was a problem hiding this comment.
This url does not look stable (newer releases will replace the archive), because it does not contain a version number. Is there a different source we can rely on?
There was a problem hiding this comment.
If not uploading to archive.org, is an option.
There was a problem hiding this comment.
No, I already reported to upstream and asked for semantic versioning.
leenaars
force-pushed
the
srcml
branch
2 times, most recently
from
b416c83 to
3cc66ca
Compare
| name = "srcml-${version}"; | ||
|
|
||
| src = fetchurl { | ||
| url = "http://www.sdml.cs.kent.edu/lmcrs/srcML-src.tar.gz"; |
There was a problem hiding this comment.
I still would like to see either an versioned upstream url or a different source.
|
It seems that you need to add |
Motivation for this change
Useful tool for source code analysis. See https://en.wikipedia.org/wiki/SrcML
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)