Skip to content

Commit

Permalink
wine-staging: Fix SHA256 hash
Browse files Browse the repository at this point in the history 
In c6b3c66, the unstable version has
been bumped to 2.6.

Unfortunately the staging source is re-using the version attribute from
the unstable source and thus has been bumped as well.

I have built wineStaging on x86_64-linux and it now succeeds.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
Cc: @FRidh
  • Loading branch information
@aszlig
aszlig committed Apr 23, 2017
1 parent c83a2f2 commit f84b817
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkgs/misc/emulators/wine/sources.nix
View file
Expand Up @@ -31,6 +31,7 @@ in rec {
};

unstable = fetchurl rec {
# NOTE: Don't forget to change the SHA256 for staging as well.
version = "2.6";
url = "https://dl.winehq.org/wine/source/2.x/wine-${version}.tar.xz";
sha256 = "1h5ajw50fax2pg9p4wch6824zxdd85g2gh9nkbllfxj3ixsn9zz6";
Expand All @@ -39,7 +40,7 @@ in rec {

staging = fetchFromGitHub rec {
inherit (unstable) version;
sha256 = "1l0sjbsajr4m7w3ar2ljwr3ffmwyv57g85a068ard3v8fv4nil22";
sha256 = "1j1fsq7pb7rxi7ppagrk93gmg5wk3anr9js0civxiqd3h8d4lsz2";
owner = "wine-compholio";
repo = "wine-staging";
rev = "v${version}";
Expand Down

2 comments on commit f84b817

@danbst
Copy link
Contributor

@danbst danbst commented on f84b817 Apr 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks bad. Perhaps better remove inherit (unstable) version; and add assert (unstable.version == version) ? So users of staging will see error fast?

It's too much luck that you've spotted this.

@FRidh
Copy link
Member

@FRidh FRidh commented on f84b817 Apr 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or perhaps a perfect example of why to cc maintainers :)

Please sign in to comment.