add skypeforlinux beta (new) #25155
add skypeforlinux beta (new) #25155
Conversation
PanAeon
changed the title
| description = "Linux client for skype"; | ||
| homepage = "https://www.skype.com"; | ||
| license = licenses.unfree; | ||
| platforms = [ "x86_64-linux" ]; |
There was a problem hiding this comment.
Do you want to maintain this package?
There was a problem hiding this comment.
Sure, I'll add myself as a maintainer. I'll try to update pull request later today.
|
|
||
| for file in $(find $out -type f \( -perm /0111 -o -name \*.so\* \) ); do | ||
| patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" "$file" || true | ||
| patchelf --set-rpath ${rpath}:$out/share/skypeforlinux $file || true |
There was a problem hiding this comment.
Move patchelf to postFixup phase. Then also using LD_LIBRARY_PATH should be not necessary.
You can also do --set-interpreter and --set-rpath in one shot.
There was a problem hiding this comment.
@Mic92 I have added postFixup phase. I'm new to nix so could have done something stupid. Please review the new changes. Thnx
|
How about calling the attribute |
|
@FRidh, well, we can certainly do that, but the two apps don't share much in common. I guess there are people that would prefer keeping old skype client even after the release of the new one. How about |
|
@PanAeon at that point we can use |
PanAeon
force-pushed
the
feature-skypeforlinux
branch
from
0119235
to
18de0c3
Compare
|
@FRidh all right, let's use attribute name |
|
Upstream names both the package and the executable |
Motivation for this change
Add skypeforlinux client. See #25152 for details.
Things done
What's working (tested): audio calls, group calls, smiles, inline media
What's not working: credentials are not saved to keychain so user need to input them each time skype starts
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)