Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ucommon: 6.3.1 -> 7.0.0 #25161

Merged
merged 2 commits into from Apr 24, 2017
Merged

ucommon: 6.3.1 -> 7.0.0 #25161

merged 2 commits into from Apr 24, 2017

Conversation

armijnhemel
Copy link
Contributor

Motivation for this change

update to new version, not tested in depth.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@armijnhemel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Fuuzetsu, @wkennington and @vcunat to be potential reviewers.

@Mic92
Copy link
Member

Mic92 commented Apr 24, 2017

sipwitch is not compatible with ucommon 7.0. cc @viric
There is a minor release of sipwitch, but it has the same problems.

@armijnhemel
Copy link
Contributor Author

Yes, I know, latest sipwitch needs ucommon 7.0.0:

libsipwitch.pc:Requires: ucommon >= 7.0.0
PKGBUILD:depends=('ucommon>=7.0.0' 'avahi' 'libeXosip2' 'pkgconfig')
sipwitch.spec:BuildRequires: ucommon-devel >= 7.0.0

@Mic92
Copy link
Member

Mic92 commented Apr 24, 2017 •
edited

libsipwitch != sipwitch. We probably need both ucommon 6.x and ucommon 7.x

@armijnhemel
Copy link
Contributor Author

I actually cut/paste that from the build files of the latest sipwitch :-)

@Mic92
Copy link
Member

Mic92 commented Apr 24, 2017 •
edited

I checked the following https://mirror.netcologne.de/gnu/sipwitch/sipwitch-1.9.9.tar.gz which source do you refer to?

@armijnhemel
Copy link
Contributor Author

Actually 1.9.15 was released in December 2015:

http://mirror.netcologne.de/pub/gnu/sipwitch/sipwitch-1.9.15.tar.gz

@armijnhemel
Copy link
Contributor Author

Don't trust alphabetical ordering on FTP sites ;-)

@Mic92
Copy link
Member

Mic92 commented Apr 24, 2017

Can you upgrade this package here as well?

@armijnhemel
Copy link
Contributor Author

Sure, but I was told to do atomic commits ;)

@Mic92
Copy link
Member

Mic92 commented Apr 24, 2017

in a separate commit in this pull request.

@armijnhemel
Copy link
Contributor Author

ok, done (I think)

@Mic92 Mic92 merged commit 5793e97 into NixOS:master Apr 24, 2017
@armijnhemel armijnhemel deleted the ucommon branch April 29, 2017 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@armijnhemel @mention-bot @Mic92