Quakespasm: init at 0.92.1 #25160
Quakespasm: init at 0.92.1 #25160
Conversation
pkgs/games/quakespasm/default.nix
Outdated
|
|
||
| enableParallelBuilding = true; | ||
|
|
||
| platforms = ["x86_64-linux"]; |
There was a problem hiding this comment.
this should be moved to meta. also, you probably want to use stdenv.lib.platforms.linux instead of hardcoding x86_64-linux, to allow the package to be built on 32 bit as well.
| Quakespasm utilizes either the SDL or SDL2 frameworks, so choose which one | ||
| works best for you. SDL is probably less buggy, but SDL2 has nicer features | ||
| and smoother mouse input - though no CD support. | ||
| ''; |
There was a problem hiding this comment.
do you want to maintain this package?
There was a problem hiding this comment.
Hey yes of course that would be nice :D
There was a problem hiding this comment.
Then include yourself as maintainer in the meta section and add yourself to lib/maintainers.nix. :)
pkgs/games/quakespasm/default.nix
Outdated
| name = "quakespasm-${version}"; | ||
| majorVersion = "0.92"; | ||
| version = "${majorVersion}.1"; | ||
| platform = "amd64"; |
There was a problem hiding this comment.
Why do you need to define platform here? I think this can be removed as it doesn't do anything (except being an environment variable during the build).
pkgs/games/quakespasm/default.nix
Outdated
| ''; | ||
|
|
||
| platforms = stdenv.lib.platforms.linux; | ||
| maintainer = stdenv.lib.maintainers.m3tti; |
There was a problem hiding this comment.
We only support maintainers (and then it is a list).
And then you could squash into one commit and force-push to the PR branch.
Motivation for this change
Loves Quake1 and wanted to share the love with the nix community
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)