Add more configuration options for zsh-syntax-highlighting #25153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ma27, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bjornfor and @offlinehacker to be potential reviewers. |
Mic92
reviewed
Apr 23, 2017
| @@ -84,22 +84,13 @@ in | |||
| type = types.bool; | |||
| }; | |||
|
|
|||
| enableSyntaxHighlighting = mkOption { | |||
There was a problem hiding this comment.
Please add this deprecation in ./nixos/modules/rename.nix
|
@Mic92 done |
…etion into its own module
7 tasks
ambrop72
pushed a commit
to ambrop72/nixpkgs
that referenced
this pull request
Jun 21, 2017
…odule (NixOS#25153) * programs.zsh: factor zsh-syntax-highlighting out into its own module * programs.zsh.syntax-highlighting: add `highlighters` option * programs.zsh: document BC break introduced by moving zsh-syntax-completion into its own module (cherry picked from commit 0a12aaf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
(similar to #25140)
I'd like to have a fully declarative configuration for my ZSH which consists of nix expressions.
Right now it's already possible to enable zsh-syntax-highlighting globally using
programs.zsh, but it's not possible to set thehighlightersoption using nix expressions which is used to configuration which highlighters should be used byzsh-syntax-highlighting.I tested it in a test VM using the following configuration:
I created the VM using the following command:
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)