kile: build with okular for embedded viewer #25151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttuegel
requested changes
Apr 23, 2017
| @@ -48,6 +49,7 @@ let | |||
| kparts | |||
| ktexteditor | |||
| kwindowsystem | |||
| okular.unwrapped | |||
There was a problem hiding this comment.
You should also add Okular to the paths argument of kdeWrapper below, otherwise Kile will not find Okular at runtime unless it is installed system-wide.
kile: build with okular for embedded viewer
|
looks good now, right? |
ttuegel
approved these changes
Apr 25, 2017
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Build with okular libraries so the embedded viewer works.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)