brightbox-image: switch to use the common make-disk-image.nix #25166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@copumpkin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rbvermaa, @oxij and @edolstra to be potential reviewers. |
7 tasks
7 tasks
|
Ping @rbvermaa 馃槃 |
|
Ping @rbvermaa again 馃槃 |
|
Any update on this pull request? |
|
Closing due to lack of activity, feel free to reopen this if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Avoid duplication. I can't test this unfortunately; @rbvermaa do you have an easy way to test it before we merge? I don't want to break it.
Also, for #24973, I'm curious if you have ideas for what it would mean to write a VM test to simulate Brightbox (which I'd never even heard of until I searched for duplicated image generation code 馃槃)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)