Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed package name in example command #25162

Closed
wants to merge 3 commits into from

Conversation

drawnwren
Copy link
Contributor

Package is called oh-my-zsh.

Motivation for this change

Small error.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@drawnwren, thanks for your PR! By analyzing the history of the files in this pull request, we identified @scolobb, @NeQuissimus and @kjanosz to be potential reviewers.

@scolobb
Copy link
Contributor

scolobb commented Apr 23, 2017

Ah right, @drawnwren , thanks for spotting the glitch!

Could you please change the commit message to fit with the contributing guidelines?

kamilchm and others added 2 commits April 23, 2017 22:09
PR NixOS#815 has already been cherry-picked into the default nix version 1.11.8.
Typo in original command. oh-my-zsh-git -> oh-my-zsh
@NeQuissimus
Copy link
Member

NeQuissimus commented Apr 23, 2017

@drawnwren Somehow some other commits found their way into this PR

@drawnwren
Copy link
Contributor Author

@NeQuissimus @scolobb it was easier to just close this and resubmit a PR #25163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants