oh-my-zsh: changed example command #25163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a typo in the example command. oh-my-zsh-git -> oh-my-zsh
|
@drawnwren, thanks for your PR! By analyzing the history of the files in this pull request, we identified @scolobb, @NeQuissimus and @kjanosz to be potential reviewers. |
7 tasks
Mic92
reviewed
Apr 24, 2017
| @@ -64,7 +64,7 @@ stdenv.mkDerivation rec { | |||
| To copy the Oh My Zsh configuration file to your home directory, run | |||
| the following command: | |||
|
|
|||
| $ cp -v $(nix-env -q --out-path oh-my-zsh-git | cut -d' ' -f3)/share/oh-my-zsh/templates/zshrc.zsh-template ~/.zshrc | |||
| $ cp -v $(nix-env -q --out-path oh-my-zsh | cut -d' ' -f3)/share/oh-my-zsh/templates/zshrc.zsh-template ~/.zshrc | |||
There was a problem hiding this comment.
You might be also interested in our recent oh-my-zsh module
There was a problem hiding this comment.
Ah, that looks very good! Actually, better than then having a separate oh-my-zsh package.
@NeQuissimus, what do you think? Should we drop this package in favour of the module?
There was a problem hiding this comment.
no the module depends on the package.
There was a problem hiding this comment.
Ah, OK, I wasn't attentive enough :-( Thanks for pointing out @Mic92!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a typo in the example command. oh-my-zsh-git -> oh-my-zsh
Motivation for this change
Same as #25162 , but properly formatted and without extra commits.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)