Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squad antennae CommNet support #1634

Merged
merged 3 commits into from
May 25, 2017
Merged

Squad antennae CommNet support #1634

merged 3 commits into from
May 25, 2017

Conversation

PhineasFreak
Copy link
Contributor

Change log:

  • Fix the CommNet support
  • Decrease the maximum temperatures (electronic parts).
  • Improve the RT descriptions.

Notes:

  • The CommNet ranges have been calculated with a mix of the available CommNet station ranges, meaning that they need to be placed in the tech tree accordingly.
Antenna Name Station Level
Communotron 16-S Level 1
Communotron 16 Level 2
DTS-M1 Level 2
Communotron HG-55 Level 2
HG-5 Level 2
RA-2 Level 2
Communotron 88-88 Level 3
RA-15 Level 3
RA-100 Level 3
  • There is a bug regarding the CustomBarnKit DSN ranges that requires a reload of the MM patches before the correct antenna ranges are set. Reload them before entering the SPH/VAB.

@stratochief66
Copy link
Member

Looks good to me. I don't know the most about the Comms system, so this should get a second set of eyes, and also some in-game testing.

@PhineasFreak
Copy link
Contributor Author

The only thing "missing" is a constant EC consumer even when not transmitting (much like the RT antennae). That can be fixed in a later patch with the ModuleGenerator hack.

@stratochief66 stratochief66 merged commit c8071ce into KSP-RO:master May 25, 2017
@PhineasFreak PhineasFreak deleted the RO-Squad-Antenna-Updates branch May 26, 2017 06:41
@PhineasFreak PhineasFreak mentioned this pull request Jun 19, 2017
Closed
Bornholio
Bornholio reviewed Jun 19, 2017
View reviewed changes
GameData/RealismOverhaul/RO_SuggestedMods/Squad/RO_Squad_Communication.cfg
@antennaType = DIRECT
@antennaCombinable = True
%antennaCombinableExponent = 1
@antennaPower = 32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what think needs a value ~4-8Mm to give lunar rating without RT installed. More if it is supposed to be lunar rated with L1 DSN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bornholio Bornholio Bornholio left review comments

Assignees
No one assigned
Labels
Completed 1 Review Pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PhineasFreak @stratochief66 @Bornholio