pysrt: init at 1.1.1 #25884
Merged
pysrt: init at 1.1.1 #25884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Mic92
reviewed
May 20, 2017
pkgs/top-level/python-packages.nix
Outdated
| @@ -9148,6 +9148,24 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| pysrt = buildPythonApplication rec { | |||
There was a problem hiding this comment.
Please read: https://github.com/nixos-users/wiki/wiki/Python-libraries#contribution-guidelines
regarding adding packages directly pkgs/top-level/python-packages.nix. Also buildPythonPackage should be used here instead of buildPythonApplication.
There was a problem hiding this comment.
Sorry, I read somewhere else (nixpkgs manual IIRC) that they should be added here, I'll move it.
pysrt is available both as a library and as an application, that's why it uses buildPythonApplication.
|
Thanks @Mic92! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Dependency of subliminal, which I want to add later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)