confluent-kafka: init at 0.9.4 #25879
Conversation
|
@mlieberman85, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer. |
mlieberman85
force-pushed
the
add-kafka
branch
2 times, most recently
from
86e2001 to
8f22fc1
Compare
|
Likely they passed on Mac because you're running without sandbox and so setuptools was able to download the package that is needed for the tests. |
|
Looks like I need to also add 3 python avro packages (avro-python3, avro, fastavro.) Should I put those in separate pull requests? |
|
I'd just add more commits to this PR (we generally try to keep one package per commit), but keep a single PR. |
|
Looks like there's actually the right avro package I need already in nixpkgs. Got the tests to find the avro package, but I'm now running into an issue where it can't find verifiable_client. verifiable_client is a module included in the tests folder of the python source of this package. Any tips to get nix to see it? |
Disabled tests for python 3 since the 0.9.4 release has failing tests when run under python 3.
|
@FRidh @copumpkin I updated my PR. Turns out the tests were failing because of some missing packages, but even after installing them they still fail because of issues with their tests (for python 3) in that release. I fixed the imports to get it working with avro support and with python3. |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)