Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings to MD5 and SHA1 hash documentation #4426

Merged
merged 3 commits into from Jun 2, 2017

Conversation

RX14
Copy link
Contributor

@RX14 RX14 commented May 18, 2017

Fixes #2743.

I'm not 100% on the wording of the warnings.

@@ -1,6 +1,9 @@
require "./base"

# Implements the MD5 digest algorithm.
#
# Warning: MD5 is no longer a cryptograpically safe hash, and should not be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "cryptographically"

Copy link
Contributor Author

@RX14 RX14 May 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Papierkorb
Copy link
Contributor

The term should be cryptographically secure, not "safe".
The secure applications isn't clear enough to me, people will never assume that what they're doing can have security implications. What about something along the line of .. and should not be used in security-related components, like password checks. Still not awesome, but hopefully makes it more clear that one of the primary use-cases, password hashing, isn't a good fit.

@mverzilli mverzilli added this to the Next milestone Jun 2, 2017
@mverzilli mverzilli merged commit b8f1504 into crystal-lang:master Jun 2, 2017
@mverzilli
Copy link

Thanks @RX14!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants