subliminal: init at 2.0.5 #25889
Merged
subliminal: init at 2.0.5 #25889
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
May 20, 2017
pkgs/top-level/python-packages.nix
Outdated
| @@ -9367,6 +9367,29 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| subliminal = buildPythonApplication rec { | |||
There was a problem hiding this comment.
Please read: https://github.com/nixos-users/wiki/wiki/Python-libraries#contribution-guidelines
regarding adding packages directly pkgs/top-level/python-packages.nix.
There was a problem hiding this comment.
I read that I should add it here in the nixpkgs manual, I'll move it to its own dir and then import.
There was a problem hiding this comment.
Heh, I slightly misread the nixpkgs manual.
umazalakain
force-pushed
the
init-subliminal
branch
from
8555b1a to
18459a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add subliminal -- library and cli tool for finding and downloading subtitles for shows and moves.
Work in progress
This commit is blocked until the following PRs get accepted:
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)