LB-157: Handle bad listens in a smarter way in influx-writer #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recursively divide the data into two parts until we find the listen that was failing. This means that only the bad listen gets rejected and not an entire batch.
|
As discussed on IRC, it is hard to find a bad listen that our API accepts but influx rejects, so I haven't added an integration test for this. However this functionality still is important because exceptions have been triggered in the past and can happen in the future also. |
mayhem
requested changes
May 22, 2017
influx-writer/influx-writer.py
Outdated
| while True: | ||
| try: | ||
| self.ls.insert(data) | ||
| done = True |
There was a problem hiding this comment.
You could skip the whole done flag if you just returned len(data) here -- that would also simplify the code below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recursively divide the data into two parts until we find the listen
that was failing. This means that only the bad listen gets rejected
and not an entire batch.