google-chrome: 57.0.2987.133 -> 58.0.3029.96 #25508
Merged
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stable: 57.0.2987.133 -> 58.0.3029.96 beta: 58.0.3029.68 -> 59.0.3071.36 dev: 59.0.3067.0 -> 60.0.3088.3
benley
added
the
8.has: package (update)
|
It seems like this doesn't build: |
|
@benley any idea why this builds for you but not on hydra? |
|
Note that the name of the commit is wrong: this is chromium, note chrome. |
|
Did builder changes not get committed? |
|
Agh crap, I failed to realize that this would affect the chromium builds and not just the google-chrome debs. Is there an obvious fix? Please feel free to revert this commit if it's going to take a while to find a proper fix, because I won't have time to work on it until tomorrow. |
|
(for what it's worth, it's not incorrect to describe this as google-chrome, because it actually is the way to update the Chrome derviations. I guess it's also chromium, though.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stable: 57.0.2987.133 -> 58.0.3029.96
beta: 58.0.3029.68 -> 59.0.3071.36
dev: 59.0.3067.0 -> 60.0.3088.3
Motivation for this change
Upstream release
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)