tw-rs: init at 0.1.26 #25514
Closed
tw-rs: init at 0.1.26 #25514
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
May 5, 2017
pkgs/misc/tw-rs/default.nix
Outdated
| description = "Twitter command-line interface written in rust"; | ||
| homepage = https://github.com/vmchale/tw-rs; | ||
| license = licenses.bsd3; | ||
| #maintainers = with maintainers; [ gebner ]; |
There was a problem hiding this comment.
Since this is your project, do you want to maintain this?
Mic92
reviewed
May 6, 2017
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| cp -p target/release/tw $out/bin/ | ||
| ''; |
There was a problem hiding this comment.
I was able to remove this phase, when building the package
|
I squashed your commits into one. It would be helpful in the future to not use |
vcunat
added a commit
that referenced
this pull request
May 6, 2017
|
Actually added you to the maintainer list in 477fa42. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add tw-rs to nixpkgs
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)