-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
Python: check if multiple versions of a package in a closure #25506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
While we try to prevent having multiple versions of Python packages it still sometimes happens we need them. It also occasionally happens that we end up with multiple versions of the same package in one closure, and that is something Python cannot handle. Currently we check for this after building the package. In most cases we might be able to catch this already during evaluation time, by asserting we do not have any duplicate name parts of Python derivations.
To do:
|
@@ -88,6 +123,9 @@ in { | |||
|
|||
vowpalwabbit = callPackage ../development/python-modules/vowpalwabbit { pythonPackages = self; }; | |||
|
|||
# unique = assertUniqueNames [ self.django_1_6.name self.django_1_8.name self.numpy.name ]; | |||
unique = assertUniquePythonPackages [ self.django_1_6 self.django_1_8 self.numpy ]; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garbas this is what you meant, right? This we could now implement in the builder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FRidh 👍 looks like a good start
I suppose this should be done automatically by buildPythonPackage
and sorry for the delay .. i'm slowly getting back to online life 😄
This is stalled and should probably be closed. @FRidh |
Thank you for your contributions.
|
I marked this as stale due to inactivity. → More info |
Thy will be done. |
While we try to prevent having multiple versions of Python packages it
still sometimes happens we need them. It also occasionally happens that
we end up with multiple versions of the same package in one closure, and
that is something Python cannot handle.
Currently we check for this after building the package. In most cases we
might be able to catch this already during evaluation time, by asserting
we do not have any duplicate name parts of Python derivations.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)