Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: 2.53 -> 2.55 #25071

Closed
wants to merge 1 commit into from
Closed

jenkins: 2.53 -> 2.55 #25071

wants to merge 1 commit into from

Conversation

earldouglas
Copy link
Member

Motivation for this change

Get rid of the nag message in Jenkins about downloading the latest .war file.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Apr 25, 2017

Applied in fce59d4 after running the NixOS tests. Thank you!

@grahamc grahamc closed this Apr 25, 2017
@earldouglas
Copy link
Member Author

Applied in fce59d4 after running the NixOS tests.

@grahamc Can you point me to docs on how to run the NixOS tests? I'd like to do that for future PRs.

@earldouglas earldouglas deleted the jenkins-2.55 branch April 25, 2017 18:45
@grahamc
Copy link
Member

grahamc commented Apr 25, 2017 via email

@earldouglas
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants