Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulseaudio: enable if sound is enabled #25077

Closed
wants to merge 0 commits into from
Closed

pulseaudio: enable if sound is enabled #25077

wants to merge 0 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 21, 2017

This and similar PRs like #29250 were NACKed all the time, because pulseaudio is a not really required layer over ALSA sound server (which already works out of box for usual scenarios). While it gives some benefits, it breaks some things (like JACK?) and gives latency overhead.
Desktop environment that depend on PA may implicitly enable it via service modules, in other cases user may manually enable PA if she uses software which doesn't work w/o PA or just use apulse proxy.

@mention-bot
Copy link

@gnidorah, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @aszlig and @wkennington to be potential reviewers.

@ghost ghost mentioned this pull request Apr 21, 2017
@edolstra
Copy link
Member

Hm, are Nix packages built for Pulse by default? I though we mostly assumed just ALSA.

If we do require Pulse by default, we should probably enable it automatically if sound.enable is set (which is enabled by default).

@grahamc grahamc changed the title nixos-generate-config: add pulseaudio option pulseaudio: enable if sound is enabled Apr 25, 2017
@oxij
Copy link
Member

oxij commented Apr 29, 2017 via email

@7c6f434c
Copy link
Member

7c6f434c commented Apr 29, 2017 via email

@oxij
Copy link
Member

oxij commented Apr 29, 2017 via email

@bjornfor
Copy link
Contributor

Also, it doesn't work too well with other pro-audio software, adds
perceptible latency and stutter.

I thought it'd work well to mix pulseaudio and jackd using option 4 here:
http://jackaudio.org/faq/pulseaudio_and_jack.html

(Didn't test it)

@7c6f434c
Copy link
Member

7c6f434c commented Apr 29, 2017 via email

@oxij
Copy link
Member

oxij commented Apr 29, 2017 via email

@oxij
Copy link
Member

oxij commented Apr 29, 2017 via email

@7c6f434c
Copy link
Member

7c6f434c commented Apr 29, 2017 via email

@7c6f434c
Copy link
Member

7c6f434c commented Apr 29, 2017 via email

@ghost ghost changed the title pulseaudio: enable if sound is enabled pulseaudio: match nixpkgs.config.pulseaudio and hardware.pulseaudio.enable May 2, 2017
@oxij
Copy link
Member

oxij commented May 3, 2017 via email

@oxij
Copy link
Member

oxij commented May 4, 2017 via email

@ghost ghost closed this May 10, 2017
@ghost ghost deleted the master3 branch May 10, 2017 17:53
@ghost ghost changed the title pulseaudio: match nixpkgs.config.pulseaudio and hardware.pulseaudio.enable . May 10, 2017
@grahamc grahamc changed the title . pulseaudio: match nixpkgs.config.pulseaudio and hardware.pulseaudio.enable May 10, 2017
@ghost ghost changed the title pulseaudio: match nixpkgs.config.pulseaudio and hardware.pulseaudio.enable . May 10, 2017
@ghost ghost restored the master3 branch May 10, 2017 19:22
@ghost ghost reopened this May 10, 2017
@ghost ghost closed this May 10, 2017
@ghost ghost deleted the master3 branch May 10, 2017 19:24
@ghost ghost changed the title . pulseaudio: enable if sound is enabled Nov 22, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants