fzf: Expose interactive shell scripts #25080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that while those scripts have 'completion' in their name, they are not a completion scripts that should be added to 'bash-completion.d' and friends. Explicitly listing `outputsToInstall` is necessary so we can have all the goodise (vim-plugin, shell scripts) in our `~/.nix-profile` when using `nix-env`. See NixOS#24717 (comment)
|
Don't install them to out but rather to |
|
@dezgeg But then it's logical to drop multiple outputs altogether, isn't it? |
|
No, |
|
If these are static libraries, maybe it is more natural to install them to |
binarin
added a commit
to binarin/nixpkgs
that referenced
this pull request
Jul 28, 2017
So that helper scripts can be easily sourced in interactive shell configuration. `autojump` package was already present and had the same requirements for findind a `share` folders, so I took an inspiration there. I beleive this is a better alternative to: - NixOS#25080 - NixOS#27058 Replacing `$out/share/shell` with `$bin/share/fzf` was necessary to prevent dependency loop in produced derivations.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that while those scripts have
completionin their name, theyare not a completion scripts that should be added to
bash-completion.dand friends.Explicitly listing
outputsToInstallis necessary so we can have allthe goodies (vim-plugin, shell scripts) in our
~/.nix-profilewhenusing
nix-env. See#24717 (comment)
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)