openvpn service: source up/down scripts #25079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fadenb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MarcWeber, @edolstra and @ericsagnes to be potential reviewers. |
source the up/down scripts instead of executing them to avoid loosing access to special variables like $1
fadenb
force-pushed
the
openvpn_source_scripts
branch
from
f206d32
to
9248692
Compare
|
I updated the PR. The up/down scripts are each written to a file and then sourced. |
|
Applied in 50ad243, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
source the up/down scripts instead of executing them to avoid loosing
access to special variables like $1
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)