Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] albert: 0.10.2 -> 0.11.1 #25083

Closed
wants to merge 1 commit into from
Closed

[WIP] albert: 0.10.2 -> 0.11.1 #25083

wants to merge 1 commit into from

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 21, 2017

Motivation for this change

Update albert to version 0.11.1.

Changes.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ericsagnes and @PierreR to be potential reviewers.

@romildo
Copy link
Contributor Author

romildo commented Apr 21, 2017 •
edited

albert-0.11.1 fails to compile on NixOS unstable:

[...]
Scanning dependencies of target albert
[ 28%] Building CXX object src/application/CMakeFiles/albert.dir/main.cpp.o
[ 29%] Linking CXX executable ../../bin/albert
/nix/store/8yb0smqwyf3da339b5kjhw8vwlslrdp0-binutils-2.28/bin/ld: warning: libglobalshortcut.so, needed by ../../lib/libalbertcore.so, not found (try using -rpath or -rpath-link)
/nix/store/8yb0smqwyf3da339b5kjhw8vwlslrdp0-binutils-2.28/bin/ld: warning: libxdg.so, needed by ../../lib/libalbertcore.so, not found (try using -rpath or -rpath-link)
../../lib/libalbertcore.so: undefined reference to `HotkeyManager::unregisterHotkey(int)'
../../lib/libalbertcore.so: undefined reference to `HotkeyManager::hotKeyPressed()'
../../lib/libalbertcore.so: undefined reference to `HotkeyManager::HotkeyManager(QObject*)'
../../lib/libalbertcore.so: undefined reference to `HotkeyManager::registerHotkey(QString const&)'
../../lib/libalbertcore.so: undefined reference to `HotkeyManager::staticMetaObject'
../../lib/libalbertcore.so: undefined reference to `HotkeyManager::~HotkeyManager()'
../../lib/libalbertcore.so: undefined reference to `XdgIconLookup::iconPath(QString, QString)'
../../lib/libalbertcore.so: undefined reference to `HotkeyManager::registerHotkey(int)'
collect2: error: ld returned 1 exit status
make[2]: *** [src/application/CMakeFiles/albert.dir/build.make:96: bin/albert] Error 1
make[1]: *** [CMakeFiles/Makefile2:86: src/application/CMakeFiles/albert.dir/all] Error 2
make: *** [Makefile:128: all] Error 2

It seems related to albertlauncher/albert#437 and albertlauncher/albert#442.

Help is needed to fix this.

/cc @ericsagnes @PierreR

@PierreR
Copy link
Contributor

PierreR commented Apr 21, 2017

I made a similar request for help a couple weeks ago when I realised I could not update up to 0.10.2... So I really don't know how to fix this.

@ericsagnes
Copy link
Contributor

Sorry, I have no idea on how to fix this error.

@7c6f434c
Copy link
Member

7c6f434c commented May 1, 2017

I don't like how I fixed this, but should work…

Now in master; does it work OK and should this PR be closed?

@romildo
Copy link
Contributor Author

romildo commented May 1, 2017

It works for me. Thanks.

@7c6f434c 7c6f434c closed this May 1, 2017
@romildo romildo deleted the upd.albert branch May 1, 2017 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@romildo @mention-bot @PierreR @ericsagnes @7c6f434c