Handle depiction corner case, do not put wavy bonds on unspecified do… #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uble bonds that aren't Sp2 atoms (e.g. Cis/Trans).
egonw
reviewed
Apr 20, 2017
| default: | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
Just saying... this kind of local atom type has caused a lot of issues in the past.
(no action needed)
There was a problem hiding this comment.
The actual real fix here is to resolve how we store stereochemistry. DoubleBondStereoElement et al needs a third state (unknown).
egonw
reviewed
Apr 20, 2017
| case 14: // Si | ||
| case 32: // Ge | ||
| // double, single, single | ||
| return chg == 0 && btypes == 0x0102; |
There was a problem hiding this comment.
So, what about a positively charged carbon with one double, one single bond...? Like C/[C+]=C\C ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uble bonds that aren't Sp2 atoms (e.g. Cis/Trans).
Before:
After: