Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getnikola/nikola
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c8a5ffd762dc
Choose a base ref
...
head repository: getnikola/nikola
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b37e435cd027
Choose a head ref
  • 3 commits
  • 3 files changed
  • 2 contributors

Commits on Apr 19, 2017

  1. Fix misplaced flags argument in re.sub() calls 

    The 4th argument of re.sub() is maximum number of substitutions,
not flags.
    @jwilk
    jwilk committed Apr 19, 2017

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    225e73a View commit details

  2. Compile _slugify_*_re with re.UNICODE flag 

    Regular expression flags cannot be passed in the sub() method.
They have to bet set at compile time.
    @jwilk
    jwilk committed Apr 19, 2017

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    903ec5e View commit details

Commits on Apr 20, 2017

  1. Merge pull request #2730 from jwilk/re.sub 

    Fix misplaced regexp flags arguments
    @Kwpolska
    Kwpolska authored Apr 20, 2017
    Copy the full SHA
    b37e435 View commit details
Loading