terraform-inventory: init at 0.7-pre #25801
Merged
+51
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
May 20, 2017
| homepage = https://github.com/adammck/terraform-inventory; | ||
| description = "Terraform state to ansible inventory adapter"; | ||
| platforms = stdenv.lib.platforms.all; | ||
| license = stdenv.lib.licenses.mit; |
There was a problem hiding this comment.
yes, I can do that. Should I add myself to lib/maintainers.nix ?
|
updated
…On Sat, May 20, 2017 at 4:05 PM, Jörg Thalheim ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/applications/networking/cluster/terraform-inventory/default.nix
<#25801 (comment)>:
> + subPackages = [ "./" ];
+
+ src = fetchFromGitHub {
+ inherit rev;
+ owner = "adammck";
+ repo = "terraform-inventory";
+ sha256 = "0wwyi2nfyn3wfpmvj8aabn0cjba0lpr5nw3rgd6qdywy7sc3rmb1";
+ };
+
+ goDeps = ./deps.nix;
+
+ meta = {
+ homepage = https://github.com/adammck/terraform-inventory;
+ description = "Terraform state to ansible inventory adapter";
+ platforms = stdenv.lib.platforms.all;
+ license = stdenv.lib.licenses.mit;
yes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#25801 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AACbCd5OIxun_uARSSzzBqK0msBkZPuxks5r7vMVgaJpZM4NbG2X>
.
|
|
Thanks! |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
adds terraform-inventory
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)