krita: 3.1.2.1 -> 3.1.3 #25302
Merged
krita: 3.1.2.1 -> 3.1.3 #25302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't much like the version/ver_min part; as the git repo tags are the full version (3.1.2.1, 3.1.3, etc) could we just use the git repo? (either KDE's or the mirror here on github, that being KDE/krita ? In other words, is there a reason to stick with the source tarball? |
|
Yes. Tarballs tend to be faster do download, easier to verify signatures, and they often contain additional pre-generated stuff. (The last point is probably invalid for krita, but e.g. for autotools-based packages it means you don't need to have autotools in build inputs.) Seems OK to me (builds and runs). |
vcunat
approved these changes
Apr 30, 2017
vcunat
added a commit
that referenced
this pull request
Apr 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New shiny
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Tested via opening a few of my projects and doing a bit of painting.