pythonPackages.ltc_scrypt: init at 1.0 #25542
Conversation
|
@asymmetric, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer. |
pkgs/top-level/python-packages.nix
Outdated
| @@ -13940,6 +13940,23 @@ in { | |||
| }; | |||
| }); | |||
|
|
|||
| ltc_scrypt = buildPythonPackage rec { | |||
There was a problem hiding this comment.
this file needs to be moved, see the header of this file.
There was a problem hiding this comment.
Should it be moved because of the following?
Python packages that do not need to be available for each interpreter version do not belong in this packages set.
If so, where should it be moved to?
There was a problem hiding this comment.
Or is it because
Expressions for Python libraries are supposed to be in
pkgs/development/python-modules/<name>/default.nix.
If that's the standard, I see almost no other library in this file following it.
There was a problem hiding this comment.
That's because its relatively new and we're in the process of actually getting all the expressions there.
There was a problem hiding this comment.
A note in that comment mentioning this could be useful. WDYT?
pkgs/top-level/python-packages.nix
Outdated
| meta = { | ||
| description = "Bindings for scrypt proof of work used by Litecoin"; | ||
| homepage = https://pypi.python.org/pypi/ltc_scrypt; | ||
| maintainers = with maintainers; [ asymmetric ]; |
There was a problem hiding this comment.
there's none i could find
There was a problem hiding this comment.
okay. See also https://nixos.org/nixpkgs/manual/#contributing
There was a problem hiding this comment.
Actually, looking at the source, it's taken from cperciva's tarsnap, and the license is similar to this one.
Since it's not a standard license, what should I do?
asymmetric
changed the title
|
No, there are no tests in the source. |
|
Looking at the description and the package contents this is an older proof of work and not more than a dump of it. Is there a particular reason you want this in Nixpkgs? |
|
Yes, it's in the PR description and in the commit message: it's a dependency of |
|
BTW, I'm happy to bundle this library in the same PR as the application that uses it, if you think it makes more sense. |
|
Yes, please. |
library needed by the electrum-ltc lightweight litecoin wallet
|
Closed in favor of #25544. |
library needed by the electrum-ltc lightweight litecoin wallet
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)