Electrum-LTC: init at 2.6.4.2 #25544
Conversation
library needed by the electrum-ltc lightweight litecoin wallet
|
@asymmetric, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer. |
| sed -i '/Created: .*/d' gui/qt/icons_rc.py | ||
| ''; | ||
|
|
||
| doInstallCheck = true; |
There was a problem hiding this comment.
buildPythonApplication runs the installCheckPhase by default, but we just call it installCheckPhase. So here you can skip the doInstallCheck line and write checkPhase instead of installCheckPhase.
lightweight litecoin wallet
|
@FRidh PTALA. |
| name = "electrum-ltc-${version}"; | ||
| version = "2.6.4.2"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
It's not on PyPi though.
| sed -i '/Created: .*/d' gui/qt/icons_rc.py | ||
| ''; | ||
|
|
||
| checkPhase = '' |
There was a problem hiding this comment.
While not a requirement it is probably nicer to make this a postPatch so that when one passes in patches they will actually be applied.
There was a problem hiding this comment.
I'm not sure I understand. Do you mean change preBuild into postPatch?
Could you clarify the reasoning here? What's the connection between build and check phases?
Thanks!
There was a problem hiding this comment.
The default checkPhase checks for patches and applies those. Now, you override the checkPhase so it won't apply anymore patches when you pass them in. Therefore, I suggest checkPhase -> postPatch.
There was a problem hiding this comment.
Is there some documentation on this logic? I don't understand why the checkPhase needs to deal with patches. Shouldn't those be handled in the patch phase?
There was a problem hiding this comment.
Oops. Of course, you're right. I must be really sleep today.
Motivation for this change
Adds Electrum-LTC, a Litecoin lightweight wallet.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)