pythonPackages.requests: point to requests2 #25540
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python package has two packages for requests, `requests` corresponding to version 1.2.3, and `requests2` corresponding to version 2.13.0. Version 1.2.3 is almost 4 years old, and by now all software should have transitioned. This commit aliases `requests` to `requests2`. Packages that stop to function should be upgraded. In the rare case that that is not possible, version 1.2.3 is still available as `requests_1` but I plan to drop that before the release of 17.09.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python package has two packages for requests,
requestscorresponding to version 1.2.3, and
requests2corresponding to version2.13.0. Version 1.2.3 is almost 4 years old, and by now all software
should have transitioned.
This commit aliases
requeststorequests2. Packages that stop tofunction should be upgraded. In the rare case that that is not possible,
version 1.2.3 is still available as
requests_1but I plan to dropthat before the release of 17.09.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)