winusb: init at 2017-01-30 #25536
Closed
winusb: init at 2017-01-30 #25536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
reviewed
May 7, 2017
pkgs/tools/misc/winusb/default.nix
Outdated
| stdenv.mkDerivation rec { | ||
| name = "winusb-2017-01-30"; | ||
|
|
||
| src = fetchzip { |
FRidh
reviewed
May 7, 2017
| description = "Create bootable USB disks from Windows ISO images"; | ||
| homepage = https://github.com/slacka/WinUSB; | ||
| license = licenses.gpl3; | ||
| maintainers = with maintainers; [ bjornfor gnidorah ]; |
There was a problem hiding this comment.
@FRidh He's the package creator https://github.com/bjornfor/nixos-config/blob/master/packages/winusb/default.nix He's doesn't like that there is no release of WinUSB yet, and so the random commit was picked by him, but I found this package already well useful and usable at that state.
There was a problem hiding this comment.
I asked upstream about making a release: https://github.com/slacka/WinUSB/issues/88
There was a problem hiding this comment.
@bjornfor Yes, thanks. On release we will bump the package.
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New package. Creates bootable USB disks from Windows ISO images
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)