Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haxe: 3.2.1 -> 3.4.2 #25538

Merged
merged 1 commit into from
May 19, 2017
Merged

haxe: 3.2.1 -> 3.4.2 #25538

merged 1 commit into from
May 19, 2017

Conversation

andyli
Copy link
Contributor

@andyli andyli commented May 5, 2017

Motivation for this change

Update the haxe package from 3.2.1 to 3.4.2.
The Haxe changelog can be found at https://github.com/HaxeFoundation/haxe/blob/3.4.2/extra/CHANGES.txt

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@andyli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aszlig, @boronine and @MarcWeber to be potential reviewers.

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, builds on Linux.

@vcunat
Copy link
Member

vcunat commented May 19, 2017

Thanks and welcome to nixpkgs!

@vcunat vcunat merged commit 56b30bf into NixOS:master May 19, 2017
vcunat added a commit that referenced this pull request May 19, 2017
@vcunat
Copy link
Member

vcunat commented May 19, 2017

Oops, this update broke hxcpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants