xen service: fix xen-bridge not setting the configured netmask #25281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The xen-bridge service accepts the option prefixLength, but does not use it to set the actual netmask on the bridge. This commit makes it set the correct netmask.
|
@michalpalka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @oxij and @peti to be potential reviewers. |
|
This close the problem as seen on #24588 |
|
cc @ts468 |
|
Should this be picked to the release branch as well? |
|
I don't have a strong opinion on this. Probably not many people rely on this, so I am not sure if it is worth doing unless @praduca needs it for anything. |
|
Actually, i dont, i only noticed it when trying to use xen. I cant even say if i will need it, i use xen on other systems and was only testing it on nixos... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
xen-bridgeservice accepts the optionprefixLength, but does notuse it to set the actual netmask on the bridge. This commit makes
it set the correct netmask.
Motivation for this change
As mentioned in #24588, the
xen-bridgeservice does not set the correct netmask on the bridge interface when theprefixLengthoption is used. Instead, the default netmask for the network class seems to be set.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)