root: 6.08.02 -> 6.09.02 #25231
root: 6.08.02 -> 6.09.02 #25231
Conversation
| url = "https://sft.its.cern.ch/jira/secure/attachment/20025/0001-std-string_view-has-no-more-to_string.patch"; | ||
| sha256 = "0ngyk960xfrcsj4vhr1ax8h85fx0g1cfycxi3k35a6ych2zmyg8q"; | ||
| }) | ||
| ./ROOT-8728-extra.patch |
There was a problem hiding this comment.
this patch was not available for as download, right?
There was a problem hiding this comment.
No, this one I had to make myself.
There is a certain commit in root-project/root#522 which might have a similar effect. But that commit is not permanently stored on github and can be removed at any moment. Also their approach is to mark operator std::string_view() as explicit which might or might not be accepted. The way I do my patching will force user to do explicit conversions, which should be always forward-compatible with future possible upstream. This is because it will not allow to write code that won't be compatible if the explicit-based solution is not accepted.
If you want, I can publish my patch as a gist and never delete it. Or I can try to put it on their bugtracker, I hope they won't mind :)
veprbl
force-pushed
the
root_6.09.02
branch
2 times, most recently
from
246e66d
to
664294a
Compare
This also fixes breakage on darwin due to LLVM4.0 migration.
I had to enable opengl because otherwise macOS build is broken.
See root commit 23f8871c7 ('Do not include OpenGL directly but use our
TGLIncludes for that purpose.')
I've enabled xml because TUnfold depends on it.
This also fixes breakage on darwin due to LLVM4.0 migration.
I had to enable opengl because otherwise macOS build is broken.
See root commit 23f8871c7 ('Do not include OpenGL directly but use our
TGLIncludes for that purpose.')
I've enabled xml because TUnfold now depends on it.
Motivation for this change
ROOT is currently broken on darwin.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)#24294