Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mono: init at 4.8 #25230

Closed
wants to merge 3 commits into from
Closed

mono: init at 4.8 #25230

wants to merge 3 commits into from

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Apr 26, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@kuznero kuznero mentioned this pull request Apr 26, 2017
7 tasks
@copumpkin
Copy link
Member

In general, we try not to maintain a bunch of different versions of things unless a package has an unstable interface and other packages depend on non-latest versions. I noticed you've submitted other versions in PRs, so I'm just wondering whether mono is unfriendly and external projects are all pinned to different versions of it. My inclination would be (based on standard semantic versioning) to have one derivation per major version number (so one for 5.x, one for 4.x, etc.), but if you tell me I'm wrong I'm not fundamentally opposed to keeping lots of versions of things around.

@kuznero
Copy link
Member Author

kuznero commented Apr 27, 2017

@copumpkin I believe that it is reasonable to have different versions of mono. It is like having different versions of jdk. Developers that develop legitimately might need to target different versions of mono. Thus it would be fare in my mind to support most widely used versions of it in Nix. I consider most widely used currently: 4.6.2 and 4.8. Version 5.x is pretty unstable as far as I know and I guess will get upgrades instead of new packages. Following that same logic I might have chosen to upgrade existing mono46 to something like mono462 - that is true. The reason for my decision was that I wanted to avoid rebuilding other dependencies that already exist.

So, the bottom line, I think it would be a good strategy going forward for mono packages to support multiple "primary" versions that folks typically target.

@copumpkin
Copy link
Member

Okay, you know best! So perhaps adopt a strategy of one attribute per minor version in widespread use? So mono44, mono46, mono48, and a mono5?

I don't really get adding a separate derivation to avoid rebuilding dependencies. That's why we update packages 😄 So it seems weird to me, even if we decide to keep several versions, to keep around a 4.6.0 and a 4.6.2.

@kuznero
Copy link
Member Author

kuznero commented Apr 27, 2017

@copumpkin makes sense. Will fix in the next couple of days.

@kuznero
Copy link
Member Author

kuznero commented Apr 30, 2017

@copumpkin I have upgraded mono46 from pointing to 4.6.0.xxx to pointing to 4.6.2.xxx. So, now it is one attribute per minor version.

Copy link
Member

@abbradar abbradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuznero Thank you very much for that work! Let's merge this first and then I'll rebase #23295 upon your patches -- I don't have much time lately so it can take a while.

Notice: I haven't tried to build this.

@disassembler
Copy link
Member

@kuznero merge conflicts can you rebase?

@abbradar
Copy link
Member

abbradar commented Nov 4, 2017

Ugh, I forgot about this one. If @kuznero won't return to this in several days I can help rebasing.

@kuznero
Copy link
Member Author

kuznero commented Nov 4, 2017

@abbradar, @disassembler, unfortunately I managed to accidentally remove my branch with mono50 and some other ones with active PRs. I will spend some time today, tomorrow re-creating branches and re-submitting PRs. Sorry for inconvenience! Will post an update when done.

@kuznero kuznero closed this Nov 6, 2017
@kuznero kuznero mentioned this pull request Nov 6, 2017
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants