New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mono: init at 4.8 #25230
mono: init at 4.8 #25230
Conversation
In general, we try not to maintain a bunch of different versions of things unless a package has an unstable interface and other packages depend on non-latest versions. I noticed you've submitted other versions in PRs, so I'm just wondering whether mono is unfriendly and external projects are all pinned to different versions of it. My inclination would be (based on standard semantic versioning) to have one derivation per major version number (so one for 5.x, one for 4.x, etc.), but if you tell me I'm wrong I'm not fundamentally opposed to keeping lots of versions of things around. |
@copumpkin I believe that it is reasonable to have different versions of So, the bottom line, I think it would be a good strategy going forward for mono packages to support multiple "primary" versions that folks typically target. |
Okay, you know best! So perhaps adopt a strategy of one attribute per minor version in widespread use? So mono44, mono46, mono48, and a mono5? I don't really get adding a separate derivation to avoid rebuilding dependencies. That's why we update packages 😄 So it seems weird to me, even if we decide to keep several versions, to keep around a 4.6.0 and a 4.6.2. |
@copumpkin makes sense. Will fix in the next couple of days. |
@copumpkin I have upgraded mono46 from pointing to 4.6.0.xxx to pointing to 4.6.2.xxx. So, now it is one attribute per minor version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kuznero merge conflicts can you rebase? |
Ugh, I forgot about this one. If @kuznero won't return to this in several days I can help rebasing. |
@abbradar, @disassembler, unfortunately I managed to accidentally remove my branch with mono50 and some other ones with active PRs. I will spend some time today, tomorrow re-creating branches and re-submitting PRs. Sorry for inconvenience! Will post an update when done. |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)