Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcitx-engines.mozc: 2.17.2313.102.1 -> 2.18.2612.102.1 and other minor fcitx packages updates #25237

Merged
merged 3 commits into from May 1, 2017

Conversation

ericsagnes
Copy link
Contributor

Motivation for this change

Should fix #25228 by updating fcitx-engines.mozc to a recent version.
Also introduce a few minor upgrades for other fcitx related packages, namely:

  • fcitx-qt5
  • fcitx-configtool

Tested in a NixOS VM with a few applications (qutebrowser & chromium).

@mt-caret Could you test this PR and check if it solves the problem you had in chromium?

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ericsagnes, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aske, @pSub and @cdepillabout to be potential reviewers.

@mt-caret
Copy link
Contributor

after cloning 'ericsagnes:pkg-update/fcitx-related' and running sudo nixos-rebuild switch -I /path/to/repo, switching input methods still doesn't work in chromium with the same error:

Apr 26 20:20:47 dn xsession[1520]: [1766:1766:0426/202047.687897:ERROR:browser_main_loop.cc(279)] Gtk: GModule (/nix/store/5a65dlh0pbnyszq7y2q63ykqq84g08qz-fcitx-with-plugins-4.2.9.1/lib/gt
Apr 26 20:20:47 dn xsession[1520]: [1766:1766:0426/202047.687930:ERROR:browser_main_loop.cc(279)] Gtk: Loading IM context type 'fcitx' faile

@ericsagnes
Copy link
Contributor Author

That's puzzling, does the error also happens with other GTK 2 applications, eg geany?

Could you try the configuration in a clean VM to see if it still happens?
For example you can use the configuration http://nixpaste.nixos.tech-meetups.tokyo/eJX3WYR7 and build a VM with the following command:

$ nixos-rebuild build-vm -I nixpkgs=/path/to/nixpkgs -I nixos-config=/path/to/configuration/file.nix

Also, mozc is somehow touchy with its main server, if you did an update and haven't rebooted afterwards, you can try to reboot that sometimes fix strange state problems.

@mt-caret
Copy link
Contributor

Installed and tried gedit and got the same sort of error and condition (can't switch input method to mozc)

(gedit:8128): Gtk-WARNING **: GModule (/nix/store/5a65dlh0pbnyszq7y2q63ykqq84g08qz-fcitx-with-plugins-4.2.9.1/lib/gtk-3.0/3.0.0/immodules/im-fcitx.so) initialization check failed: GLib version too old (micro mismatch)
(gedit:8128): Gtk-WARNING **: Loading IM context type 'fcitx' failed

I'll check if I can reproduce this behavior in a vm.

@mt-caret
Copy link
Contributor

Confirmed that the PR fixes the problem with chromium and other gtk-based applications (I tested gedit and slack)! The reason that nixos-rebuild switch wasn't working was a mistake on my part; I was under the assumption that programs.chromium.enable = true; will install chromium, and had completely forgot about installing it in my root profile.

@7c6f434c 7c6f434c merged commit 008bd11 into NixOS:master May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mozc on fcitx fails to work on Chromium
5 participants